Test "github660" does not pass with flambda
Open
Nobody has claimed this yet.
test-suite
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Hi,
While debugging flambda-related #3599 I noticed that test github660 fails on 4.10.0+flambda with the following diff:
diff --git a/test/blackbox-tests/test-cases/github660.t/run.t b/test/blackbox-tests/test-cases/github660.t/run.t.corrected
index ef75ae81b..e4d323561 100644
--- a/test/blackbox-tests/test-cases/github660.t/run.t
+++ b/test/blackbox-tests/test-cases/github660.t/run.t.corrected
@@ -10,8 +10,6 @@ When there are explicit interfaces, modules must be rebuilt.
$ echo 'let _x = 1' >> explicit-interfaces/lib_sub.ml
$ dune runtest --root explicit-interfaces
Entering directory 'explicit-interfaces'
- main alias runtest
- hello
When there are no interfaces, the situation is the same, but it is not possible
to rely on these.
I did not investigate what that means, but let's keep it somewhere not to forget.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/blackbox-tests/test-cases/github660.t/run.t and reproduce the failure using OCaml 4.10.0 with flambda. Compare the expected output with the observed diff and investigate why the explicit-interfaces test omits its output. Done means the cause is understood and the test passes with an appropriate expected result or documented fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100