ocaml / ocaml/dune

Expect tests with (implicit_transitive_deps false)

Open
#3,569 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build needs-investigation test
Dominant language
OCaml
Stars
1.9k
Forks
500
Avg merge
15h 21m
Merged PRs (30d)
277

Description

When I try setting (implicit_transitive_deps false) and try to use expect tests I get the error Unbound module Expect_test_common. I assume there's some module I'm missing but I'm not sure which - expect_test_common.ml is in ppx_expect, but explicitly adding ppx_expect to my pps list doesn't seem to help (I already have ppx_jane there). My library deps are just core, core_kernel, async, async_kernel. When I change (implicit_transitive_deps true) the expect test works properly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the report with implicit_transitive_deps false, the ppx_jane and ppx_expect preprocessors, and the stated core, core_kernel, async, and async_kernel dependencies. Start by tracing expect_test_common.ml in ppx_expect and the dependency setup; done means expect tests compile without the Unbound module error while transitive dependencies remain disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.