Custom lint ?
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Hi!
Desired Behavior
Hello, it seems that the current system makes it impossible to run a custom promotable linting action, as it is possible for ppx.
(library
(name ...)
(lint (pps ppx_yojson_conv))
will let you run dune build @lint and then dune promote
In the same manner, I would expect
(library
(name ...)
(lint (action (echo "test")))
to let produce promotable files where every one of my ml and mli file have been overridden by files containing just "test".
I know it's happening in preprocessing.ml > lint_module > | Action where the target is set to None and no promote_correction is happening, but I haven't had time to dive deeper into it to make it work yet
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in preprocessing.ml at lint_module, specifically the Action case where the issue reports that the target is set to None. Reproduce the custom lint action with dune build @lint followed by dune promote; done means the action produces promotable files for the ML and MLI sources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100