`$DUNE_WORKSPACE` should be cleared in `dune pkg` sandboxes
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Expected Behavior
The documentation let suppose that setting $DUNE_WORKSPACE should be equivalent to setting --workspace=.... I expected that environment variable to be cleared in nested calls to dune.
Actual Behavior
When building dependencies using package management, $DUNE_WORKSPACE is seen, and interpreted, by nested calls to dune in sandboxes (where it probably never makes sense), while --workspace=... is not passed on (as one would expect).
Reproduction
Tested with the nightly build in an experimental branch of setup-dune: see its log.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction in the experimental setup-dune branch and its linked Actions log, then trace how package-management sandboxes launch nested dune processes. Done means DUNE_WORKSPACE is cleared in those nested calls while explicit --workspace behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100