Building the cmo of a module of a disabled library gives a bad error
Open
Nobody has claimed this yet.
build
enhancement
- Dominant language
- OCaml
- Stars
- 1.9k
- Forks
- 500
- Avg merge
- 15h 21m
- Merged PRs (30d)
- 277
Description
Thanks for the test. The current behavior is definitely not great. The error should include that the target is missing due to a disabled library.
Originally posted by @rgrinberg in https://github.com/ocaml/dune/issues/10026#issuecomment-1945191440
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported case: build the cmo of a module belonging to a disabled library. Trace the diagnostic for the missing target and update the behavior so the error states that the target is missing because its library is disabled; done when the resulting error clearly includes that cause.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ocaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100