ocaml-dune / ocaml-dune/binary-distribution

Deployment server is defined in two places

Open
#235 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
4
Forks
12
PR merge metrics
No merged PRs in 30d

Description

As the server moved we ran into the issue that the configuration where to upload the binaries is in two places that have to be kept in sync: on of them is the action secret DEPLOY_SERVER which is used to retrieve the SSH key from the server. The other is the configuration in rclone.conf which specifies where Sandworm will upload the artifacts. This is obviously suboptimal, as that means that the same configuration change has to be done in two different places, using two different methods (changing secrets for one, updating the repo contents for the other).

Generally I think it would be better if the rclone.conf could be replaced altogether (e.g. by passing the values directly when invoking), since it currently hardcodes the configuration for Tarides but is not interesting to a general open source audience.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading rclone.conf and the deployment workflow entry points that use the DEPLOY_SERVER action secret. Trace how the SSH key and artifact destination are supplied, then determine a single configuration path that removes the duplicated server setting and works without the Tarides-specific rclone.conf. Done means deployment uses one server configuration and existing artifact uploads still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, shell
Domain
devops, release
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.