obsproject / obsproject/obs-studio

x264 does not respect "Ignore streaming service setting recommendations" for buffer size, if a custom buffer size is used

Open
#9,959 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Windows 10

OBS Studio Version

30.0.0

OBS Studio Log URL

https://obsproject.com/logs/NX11ztdDwtYUQjXv

Expected Behavior

VBV_Bufsize of the video file should reflect the used buffer size value if ignore limits is checked

Current Behavior

VBV_Bufsize of the video file is forced to 6000 if a greater value then that is used, even when the user has checked "Ignore streaming service setting recommendations"
The checkbox works fine for bitrate, but not for buffer size.

Relevant log part:

User is ignoring service bitrate limits.
buffer size:  6000

I've also verified the video file with mediainfo for the metadata, which indeed shows vbv_bufsize at 6000
If no custom buffer size is used, and ignore limits is checked, a greater then 6000 bitrate will also allow for a greater buffer size

Steps to Reproduce
  1. Go to Settings > Stream
  2. Select Twitch
  3. Check box for "Ignore streaming service setting recommendations"
  4. Go to Settings > Output
  5. Select Output Mode > Advanced
  6. Select Video Encoder > x264
  7. Check Box for "Use Custom Buffer Size" under "Encoder Settings"
  8. Enter any value that is greater then 6000 into the Buffer Size field

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue using the listed OBS Stream and Output settings, then inspect the x264 encoder-settings path responsible for the reported buffer size. Use the provided log and MediaInfo result to compare custom values above 6000 with the ignore-recommendations option; done means the resulting VBV_Bufsize honors the custom value and the existing behavior remains correct otherwise.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.