obsproject / obsproject/obs-studio
False Dialog For Settings Change
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 76.4k
- Forks
- 10.2k
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 12
Description
Operating System Info
Windows 11
Other OS
No response
OBS Studio Version
30.0.0
OBS Studio Version (Other)
No response
OBS Studio Log URL
https://obsproject.com/logs/oMcBK8ffD3YThdE5
OBS Studio Crash Log URL
No response
Expected Behavior
To not get a dialog asking if I want to save settings, when no settings have changed, when wanting to close out of the settings window
Current Behavior
Currently, with at least this circumstance, you will get the dialog that there are unsaved changes to settings when no changes have been made. Will update additional circumstances as I come across them.
Current discovered circumstance is going into settings > stream, expanding the "service" dropdown, selecting "show all", then clicking off of it to close dropdown without actually changing what service it's set to. This triggers the "apply" button to become active, and produces the unsaved changes dialog, even though there were no actual changes.
Steps to Reproduce
- Open Settings
- Go to "stream" tab
- Click on "service" dropdown
- Set to "show all"
- Click off as to not actually change what service you are set to
- Observe "apply" button becoming active and try to close the settings window
...
https://github.com/obsproject/obs-studio/assets/66339760/96b9593a-606a-4d33-a1d3-bcd5132fad0d
Anything else we should know?
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in OBS Studio 30.0.0 through Settings > Stream, using the Service dropdown and Show All option. Trace how the settings window marks changes and enables Apply after dismissing the unchanged selection. Done means unchanged settings do not enable Apply or show the unsaved-changes dialog, with the reproduction steps still passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100