Saving the replay buffer with too little disk space stops replay recording and discards the current buffer

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

30.0.0-rc2

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/jHN2NrcykeJuRweq

OBS Studio Crash Log URL

No response

Expected Behavior

When I save the replay buffer with low disk space (where there isn't enough space to store the entire recording), I expect it to continue recording and still allow me to save once I have freed up some space. The most critical thing is that the buffer is not deleted.

Current Behavior

The replay buffer is disabled, discarding the current buffer in the process and thereby deleting a possibly important replay moment, making it impossible to save it, even after freeing up the drive. This can be a very painful experience sometimes.

Steps to Reproduce

1. Enable the replay buffer
2. Save a replay onto a disk that has not enough space
3. Observe that the replay buffer is disabled and the current buffer is discarded

Anything else we should know?

Simplest fix: Continue recording and don't delete the current buffer.

Further ideas:

• Allow a backup recording drive, in case the space is full, so the entire replay can be saved immediately. Send a notification whenever something is saved to the backup recording drive
• Upon saving a replay while there is not enough disk space, store the replay in memory until either the application is closed or disk space has been freed and the save replay button has been pressed again, in which case the cached buffer is dumped to the drive. That way, even if it takes a minute to free up the drive, we get the entire replay buffer stored on the disk and we don't lose one minute of footage
• Add the option to notify the user that disk space is low if it goes below a certain threshold, after saving a replay or a recording.

Start by reproducing the failure with the listed steps on Windows 10 and review the linked OBS log. Done means that an unsuccessful replay save caused by insufficient disk space leaves the current replay buffer intact, keeps recording enabled, and permits saving after space is freed.