obsproject / obsproject/obs-studio

error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]

Open
#9,110 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Other

Other OS

FreeBSD

OBS Studio Version

29.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

n/a

OBS Studio Crash Log URL

No response

Expected Behavior

Build succeeds.

Current Behavior
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:201:54: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonString(string &&value)      : Value(move(value)) {}
                                                     ^
                                                     std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:209:58: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonArray(Json::array &&value)      : Value(move(value)) {}
                                                         ^
                                                         std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:217:60: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonObject(Json::object &&value)      : Value(move(value)) {}
                                                           ^
                                                           std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:259:72: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(string &&value)             : m_ptr(make_shared<JsonString>(move(value))) {}
                                                                       ^
                                                                       std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:262:71: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(Json::array &&values)       : m_ptr(make_shared<JsonArray>(move(values))) {}
                                                                      ^
                                                                      std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:264:72: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(Json::object &&values)      : m_ptr(make_shared<JsonObject>(move(values))) {}
                                                                       ^
                                                                       std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:362:21: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
        return fail(move(msg), Json());
                    ^
                    std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:154:46: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit Value(T &&value)      : m_value(move(value)) {}
                                             ^
                                             std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:201:48: note: in instantiation of member function 'json11::Value<json11::Json::STRING, std::string>::Value' requested here
    explicit JsonString(string &&value)      : Value(move(value)) {}
                                               ^
Steps to Reproduce

Regular build.

Anything else we should know?

clang-15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The build failure is in deps/json11/json11.cpp, with clang-15 identifying several unqualified move calls. Start by inspecting the reported constructors and fail path, then run a regular FreeBSD build; done means the build succeeds without the -Wunqualified-std-cast-call errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.