obsproject / obsproject/obs-studio

Crop/Pad Filter and Transform on Window Capture doesn't reset correctly when window is restored after being maximized in some apps (Firefox, Edge, Thunderbird...)

Open
#8,906 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

29.1.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/NVMDgmotURhHbB4o

OBS Studio Crash Log URL

No response

Expected Behavior

Using the Crop/Pad Filter (or the Transform tool) in a Window capture (in my case, capturing Firefox) should maintain the crop configured when the window is maximized and restore the window to the normal size, without doing anything more.

Current Behavior

When i set a crop filter (or the Transform tool) in a window capture with Firefox, and that window is maximized, obviously the crop change, but if i restore the window, the crop doesn't match what is showing before, like if it was moved.

However, if i change scene, or i hide/unhide the window capture source, the window shows again like i configured at first.

Steps to Reproduce
  1. I open Firefox, and i put it in a window not maximised (i use Sizer, to measure easier the width and height, in this case using the preset 1280x960 because i am in a 1080p display).

  2. In my test case, i have two window capture from the same window:

  • One capturing the Firefox page without the Firefox GUI ("Firefox Pagina")
  • Other capturing only the Firefox URL in the GUI ("Firefox URL")
  1. For both of them, i set a Crop/Pad Filter:
  • Firefox Pagina: Using relative size, only hidding the top GUI.
    OBS_CropPadIssue_CropPadRelative_FirefoxPagina
  • Firefox URL: Using absolute size, cutting only the URL part in the GUI.
    OBS_CropPadIssue_CropPadAbsolute_FirefoxURL
  1. Using a 1080p output in OBS, i have this scene:
    OBS_CropPadIssue_Preview1_WindowNormal

  2. Then, i maximised the Firefox window, causing the scene to change correspondly:
    OBS_CropPadIssue_Preview2_WindowMaximized

  3. Then, i restore the maximised Firefox to window, but the scene doesn't restore to the look in the Step 4, the crop is changed:
    OBS_CropPadIssue_Preview3_WindowWrong

  4. However, if i hide/unhide the sources, or i swap to other scene and return to this one, the sources return to the aspect in Step 4 again.

NOTE: You can also use the transform tool, as i found after some research.

Anything else we should know?

I tried to replicate this issue with Windows Explorer and Microsoft Edge, with Explorer it doesn't do the same as it works as expected, with Edge it has the same issue as Firefox.

Also, i tried in two different computers with Windows 10 and OBS Studio 29.1.2, and it happens in both of them.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on Windows 10 using OBS Studio's Window Capture with Firefox or Edge, applying the Crop/Pad filter or Transform tool. Compare the source after maximizing and restoring the window, then verify that the original crop is restored without switching scenes or hiding the source.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.