obsproject / obsproject/obs-studio

Sources flicker when undo-ing or redo-ing a deleted source

Open
#5,152 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

27.0.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/11qDjvGtaYqTB-_z

OBS Studio Crash Log URL

No response

Expected Behavior

Only the source being added/removed by undo/redo to be affected

Current Behavior

https://user-images.githubusercontent.com/1554753/129936355-a3857853-afa5-4b13-b925-f1b39ac94224.mp4

It seems that undo/redo adding/removing sources adds and removes the entirety of sources in the scene during the state restore

It should probably filter out the existing sources in the scene and only modify the diff between states

image

Steps to Reproduce
  1. Add a source to a scene with a number of other sources
  2. Delete the source from the scene
  3. Undo the source deletion
  4. Redo the source deletion
Anything else we should know?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the four-step scenario on Windows 10 using OBS Studio 27.0.1, then compare the behavior with the linked video and log. Done means undo and redo affect only the added or removed source, without flickering or modifying the other sources in the scene.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.