obsproject / obsproject/obs-studio

Filenames for recordings don't get sanitised, replay buffers do

Open
#13,786 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Other

Other OS

CachyOS

OBS Studio Version

32.2.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/VGrUm2ROHCNSTZgC

OBS Studio Crash Log URL

No response

Expected Behavior

Recording output filenames should be properly sanitised to remove illegal characters such as the colon that would not work on a filesystem such as NTFS.

Current Behavior

A recording's output filename is written to disk containing a colon, of which should have been removed. Saved replay buffers do get properly sanitised.

Steps to Reproduce
  1. Open OBS
  2. Start a recording
  3. End the recording
Anything else we should know?

The used filename formatting was %CCYY-%MM-%DD %hh:%mm:%ss. This has only been tested on Btrfs where a colon is a valid character.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in OBS 32.2.1 with the %CCYY-%MM-%DD %hh:%mm:%ss format, then compare recording filename handling with the replay-buffer sanitisation path. Done means recorded filenames no longer contain characters invalid on filesystems such as NTFS, while valid characters such as the colon on Btrfs remain appropriately handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.