obsproject / obsproject/obs-studio

Closing a VST plugin window with the red cross doesn't signal that it's closed

Open
#13,580 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

32.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/Hu7PDQBZ8yJtZgPC

OBS Studio Crash Log URL

No response

Expected Behavior
Image I would expect the "Open Plug-in Interface" button in the "Audio Filters" popup to return to its original state
Current Behavior
Image After closing the plugin window with its own red X, the button stays on "Close Plug-in Interface" and there is no way to re-open the plugin that was just closed. One has to close and re-open the "Audio Filters" popup for the button to return to normal.
Steps to Reproduce
  1. Open a VST plugin that allows the window to be closed (e.g. StereoTool)
  2. Close it using its red X
Anything else we should know?

I'm a developer for StereoTool.

Closing the plugin with the "Close Plug-in Interface" works fine, and triggers the same exact code in the VST SDK (and our plugin).
The only thing missing, is for OBS itself to detect that the plugin window is being closed by the OS.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the StereoTool VST plugin from the Audio Filters popup, then trace how OBS handles the plugin window when its red X is used instead of "Close Plug-in Interface." Done means the OS close is detected, the button returns to "Open Plug-in Interface," and the plugin can be reopened without reopening the popup.

Written by the indexing model from the issue text.

Assessment

Domain
audio-video-rtc, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.