obsproject / obsproject/obs-studio
obs-browser: Use top level obs_profile_cookies going forward
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 76.4k
- Forks
- 10.2k
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 12
Description
The cookie directories for each service integration must be moved into the root config directory, as subdirectories in their current form (obs_profile_cookies/<cookie_id>) are not supported. This is intentional, and according to Marshall this was never a supported setup. cache_path must be a direct child of the root_cache_path. Invalid cache_path is silently treated as Incognito Mode and cookies are not stored.
Usage of obs_profile_cookies/ should be changed to obs_profile_cookies_ after the migration path is merged.
Additionally, there might also be use in using a reusable key for it, rather than manually specified in every place.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect frontend/widgets/OBSBasic_Browser.cpp at the cited lines and search the repository for other obs_profile_cookies/ uses. Trace the existing migration path and the CEF cache_path/root_cache_path handling. Done means cookie directories use the supported top-level layout and old references are updated to obs_profile_cookies_.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100