obsproject / obsproject/obs-studio
Refactor out usages of sender()
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 76.4k
- Forks
- 10.2k
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 12
Description
Qt's sender() function is an older pattern from before Signals and Slots supported lambdas.
They're a legacy approach that are extremely brittle due to violating type safety and encapsulation.
Anywhere that we are using sender() should be refactored in some manner.
This does not need to be fixed in a signal PR or commit.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for usages of Qt's sender() function, starting with the example in frontend/importer/ImporterEntryPathItemDelegate.cpp around lines 155-160. Review each call site and replace the legacy pattern with an appropriate Signals and Slots approach. Done means sender() usages have been refactored without bundling the changes into a signal-related PR or commit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100