obsproject / obsproject/obs-studio
Changes to "recording filename formatting" does not apply to already-running replay buffers
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 76.4k
- Forks
- 10.2k
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 12
Description
Operating System Info
Windows 10
Other OS
No response
OBS Studio Version
30.1.2
OBS Studio Version (Other)
No response
OBS Studio Log URL
N/A
OBS Studio Crash Log URL
No response
Expected Behavior
Saving a replay should apply the "Filename formatting", as well as "Replay Buffer Filename Prefix/Suffix", as configured at the time the replay is saved
Current Behavior
The replay uses a snapshot of the "Filename formatting" and "Replay Buffer Filename Prefix/Suffix" from when the replay buffer was started
Steps to Reproduce
- Configure formatting for recordings, Settings -> Advanced -> Recording
- Start the replay buffer
- Change the Filename Formatting or Replay Buffer Filename Prefix/Suffix
- Save the changed settings
- Save a replay -- This will use the configuration from (1.) instead of (3.)
Anything else we should know?
Perhaps my use-case is somewhat unusual, but I leave the replay buffer running most of the time and occasionally make changes to the filename via websockets.
Since the replay isn't actually written to the disk until I press "save replay", I'd expect it to use the formatting configured at the time I press save, not at the time I started the replay buffer. I can understand recordings using whatever formatting is configured when you start them, since they stream-write the file to the disk, but replays live in-memory until saved, so there shouldn't be a strict need to use a snapshot of the settings.
Stopping and starting the replay buffer is not a viable solution, as it causes me to lose whatever is in the buffer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the replay-buffer save path and the Filename formatting and Replay Buffer Filename Prefix/Suffix settings named in the report as entry points. Reproduce the behavior on Windows by changing those settings while the buffer runs; done means a subsequently saved replay uses the current settings without restarting the buffer or losing buffered content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100