obsproject / obsproject/obs-studio

Fails to build against new libajantv2

Open
#10,771 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Other

Other OS

Clear Linux OS

OBS Studio Version

30.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

not in application

OBS Studio Crash Log URL

No response

Expected Behavior

Compiles against libajantv2-17.0.1

Current Behavior

Fails to find header file ntv2linuxdriverinterface.h

Steps to Reproduce
  1. Compile against system-provided libajantv2

...

Anything else we should know?

Variable names AJA_LIBRARIES_INCLUDE_DIRS, LIBAJANTV2_INCLUDE_DIRS, and LibAJANTV2_INCLUDE_DIRS are used inconsistently in the cmake file, dropping the OS-specific path appends
https://github.com/obsproject/obs-studio/blob/52ae5fc4bd518c67edd8ab94121ace05d9076892/cmake/Modules/FindLibAJANTV2.cmake#L135-L152

from the final list of include directories:
https://github.com/obsproject/obs-studio/blob/52ae5fc4bd518c67edd8ab94121ace05d9076892/cmake/Modules/FindLibAJANTV2.cmake#L171

Here is a patch to fix the naming:
backport-Fix-AJANTV2-includes-in-backport-patch.patch

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with cmake/Modules/FindLibAJANTV2.cmake, especially the include-directory handling around the referenced lines. Reproduce the build against libajantv2-17.0.1 on Clear Linux and inspect the attached patch for the reported variable-name mismatch. Done means OBS finds ntv2linuxdriverinterface.h and compiles against the system library.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.