obsproject / obsproject/obs-studio

Segfault from sceneitem infinite recursion nesting

Open
#10,466 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
76.4k
Forks
10.2k
Avg merge
4d 23h
Merged PRs (30d)
12

Description

Operating System Info

Ubuntu 22.04

Other OS

No response

OBS Studio Version

30.1.1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/rMBABOJ0DnVsKeaO

OBS Studio Crash Log URL

No response

Expected Behavior

It should not be possible to create an infinite recursion of sceneitems.

Current Behavior

It is possible to insert a scene as a sceneitem inside a group present in said scene, creating an infinite recursion, and crashing obs.

Steps to Reproduce
  1. Create Scene A
  2. Create Group A inside Scene A
  3. Create Scene B
  4. Add Scene A and Group A as sceneitems in Scene B
  5. In the "Sources" dock, drag and drop Scene A into Group A
  6. Crash
    ...
Anything else we should know?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the crash using the listed Scene A, Group A, and Scene B drag-and-drop steps, then inspect the OBS Studio log at the provided URL. Trace how a scene can be inserted into a group within that scene. Done means the invalid infinite-recursion nesting is prevented and OBS no longer crashes.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.