obsproject / obsproject/obs-browser
[block & solution] thread is blocked because of browser source
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 904
- Forks
- 267
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 2
Description
Operating System Info
Windows 11
Other OS
MAC
OBS Studio Version
30.2.3
OBS Studio Version (Other)
30.2
OBS Studio Log URL
none
OBS Studio Crash Log URL
none
Expected Behavior
no UI block
Current Behavior
I meet a block, but not reproduced again
Steps to Reproduce
MAC os
UI thread :
obs_graphics_thread:
Anything else we should know?
Suggest:
for mac os, should ProcessCef be called in browser::tick instead of browser::render ?
because in render function, so many locks have been hold before.
in tick function, there is no additional lock being hold that is more safe
by the way, I can't reproduce this issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the browser::render and browser::tick paths and how ProcessCef is called, paying attention to the locks held before each path. First establish a reproducible macOS UI or graphics-thread block; done means the blocking behavior is addressed and the relevant behavior no longer regresses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100