observation / observation/react-native-components

Change BottomSheet to accept one button or an array of buttons

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

technical
Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
2d 1h
Merged PRs (30d)
3

Description

Would be nice if this component would accept either a button or an array of buttons, so it could be used like:

       <BottomSheet buttons={{ title: i18n.t('Upload all'), onPress: onUpload }} />

instead of currently:

       <BottomSheet
          buttons={[
            {
              title: i18n.t('Upload all'),
              onPress: onUpload,
            },
          ]}
        />

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BottomSheet component and the type or definition of its buttons prop. Check how the current array form is consumed, then verify that both a single button object and an array render correctly in the requested JSX examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.