observablehq / observablehq/plot

When a reducer expects numeric input but is given non-numeric input, it should raise an error.

Open
#473 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
HTML
Stars
5.4k
Forks
244
PR merge metrics
No merged PRs in 30d

Description

Following up on https://github.com/observablehq/plot/issues/399#issuecomment-890596083. For example, if you pass ordinal data (strings) to a sum reducer, Plot could detect that and raise a helpful error rather than producing NaN output.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the reducer path for the sum operation and how ordinal string data reaches it. Add coverage for non-numeric input and verify that the reducer raises a helpful error instead of producing NaN output.

Written by the indexing model from the issue text.

Assessment

Tech stack
d3js
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.