observablehq / observablehq/plot

invalid markerEnd option for link/arrow

Open
#2,156 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
HTML
Stars
5.4k
Forks
244
PR merge metrics
No merged PRs in 30d

Description

the current markerEnd: "arrow-reverse" has no effect for both link and arrow.
Not sure if it's the design choice or bug.

    Plot.link(data, {
      markerEnd: "arrow-reverse"
    })

if it's the choice then the following line should change to Exclude<Marker, "arrow-reverse"> for link | arrow
https://github.com/observablehq/plot/blob/0032c11160e6340ce44307675d93bed382d10446/src/marker.d.ts#L93

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/marker.d.ts line 93 and trace how markerEnd is handled for link and arrow. Determine whether arrow-reverse is intentionally unsupported or whether the runtime behavior is incorrect. Done means the option's type definition and behavior are aligned with the chosen outcome.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.