observablehq / observablehq/plot

a facet or facetAnchor: "all" option?

Open
#2,014 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
5.4k
Forks
244
PR merge metrics
No merged PRs in 30d

Description

In this Plot:
facetAnchor

Plot.plot({
  marginLeft: 60,
  marks: [
    Plot.frame({ fill: "silver" }),
    Plot.barX(data, { x: "Cantidad", fx: "type", fy: "p28" })
  ]
})

we would like the silver frame to be present on all facets, including the empty ones (represented with an orange stroke). Should we add a facet: "all" or facetAnchor: "all" option?

(The orange stroke was added with Plot.frame({ stroke: "orange", facetAnchor: "empty" })).

The chart can be fixed currently by duplicating the mark:
[Plot.frame({ fill: "silver" }), Plot.frame({ fill: "silver",facetAnchor: "empty" })],

but it shows that something is missing.

Test & data: https://observablehq.com/d/faf63a6fe3950d75

(Feature request suggested by @rusosnith)

relevant links in the documentation:

(there is a small error on the axis page, where it says "null - show on every facet" it should say "null - show on every non-empty facet")

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the facet mark options documentation and the linked Observable test and data to understand how empty facets and facetAnchor are currently handled. Compare the requested all-facet frame behavior with the existing duplicated-mark workaround, and update the relevant documentation example and tests so completion demonstrates the frame on both non-empty and empty facets.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.