observablehq / observablehq/plot
Rename the “sort” option (for imputing ordinal scale domains) to “domain”
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- HTML
- Stars
- 5.4k
- Forks
- 244
- PR merge metrics
- No merged PRs in 30d
Description
Currently we use the sort option for both the sort transform and for imputing ordinal scale domains. We could avoid some ambiguity by using a separate name for the latter, especially since in the case of input order, sorting isn’t always involved.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation, documentation, and tests for the sort option used to impute ordinal scale domains. Verify how that option differs from the sort transform, then update the ordinal-domain option to use domain while keeping sort behavior for transforms unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data-visualization
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100