observablehq / observablehq/plot
Setting fillOpacity could change dot to default fill instead of stroke
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- HTML
- Stars
- 5.4k
- Forks
- 244
- PR merge metrics
- No merged PRs in 30d
Description
Setting fillOpacity without also setting fill has no effect, so we could change the default for dot such that this
Plot.dot(cars, {x: "displacement (cc)", y: "economy (mpg)", fillOpacity: 0.2}).plot()
is equivalent to this
Plot.dot(cars, {x: "displacement (cc)", y: "economy (mpg)", fill: "currentColor", fillOpacity: 0.2}).plot()
For hexbin, that would mean you could say
Plot.plot({
marks: [
Plot.dot(
cars,
Plot.hexbin(
{ fillOpacity: "count" },
{ x: "displacement (cc)", y: "economy (mpg)" }
)
)
]
})
without having to set the fill option, too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Plot.dot entry point and inspect how default fill and fillOpacity options are resolved; no file or test path is named in the issue. Use the two dot examples and the hexbin example as behavioral checks, with completion meaning fillOpacity alone produces the intended currentColor fill behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100