observablehq / observablehq/plot
crash on nullish facet data
Open
@Fil is already working on this.
Since Apr 10, 2023.
question
- Dominant language
- HTML
- Stars
- 5.4k
- Forks
- 244
- PR merge metrics
- No merged PRs in 30d
Description
I think this should throw an error, rather than crashing. Not really a bug since it's not following the general definition of data+channels, but the crashes it produces (in at least two places) show that we're controlling that y is non-null, and then expect facet.data to have a length.
export async function AAA() {
return Plot.plot({
facet: {data: null, y: ["a", "b", "c", "d"]},
marks: [Plot.dotX([1, 2, 4, 5])]
});
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.