obophenotype / obophenotype/uberon
Decide on graph walking vs EL inference for using taxon constraints to make subsets
Open
Nobody has claimed this yet.
tech
- Dominant language
- Emacs Lisp
- Stars
- 163
- Forks
- 43
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 5
Description
Current strategy to make a taxon subset:
- Add axiom Thing subClassOf part-of some NCBITaxon:nnnn
- Remove any inter-species existentials
- homology represented as reciprocal existentials
- inter-species edges (less relevant for uberon)
- Ensure all TCs are EL-ified
- never_in becomes disjointWith in-taxon some X
- Ensure NCBITaxon GCIs are added (in-taxon some X disjoint with in-taxon some Y for all sibs)
- Reason with Elk
- Eliminate all unsatisfiables
Note this has issues if we have:
- A subclass part-of some B
- B never-in-taxon
See
https://github.com/geneontology/go-annotation/issues/3942
@balhoff says he has a solution
Some additional issues with the approach
- hard to mentally reason over - logic is separated across ad-hoc filters on OPs, various pre-processing steps, property chains stored centrally in GO
- Can require 10s of gigs of memory
- this gets worse the further away from human we go
- Hard to 'customize'. E.g. GO may want to include occurs_in when making their subsets
Outline alternative strategies in this ticket
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.