obophenotype / obophenotype/uberon
Add DPs for mereological sums of structures (muscles, musculature; vessels, vasculature)
@aleixpuigb is already working on this.
Since Aug 11, 2023.
- Dominant language
- Emacs Lisp
- Stars
- 163
- Forks
- 43
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 5
Description
Uberon has historically followed FMA in drawing a distinction between Xs and Xature.
Xs form an is-a hierarchy, inferred automatically for "X P = X and R some P" e.g.
- blood vessel
- [i] hindlimb blood vessel
- [i] foot blood vessel
- [i] hindlimb blood vessel
Xature shadows the partonomy
- blood vasculature
- [p] hindlimb blood vasculature
- [p] foot blood vasculature
- [p] hindlimb blood vasculature
This is harder to infer, a known issue with OWL
same for muscles, musculature, and other structures
Maintaining the two hierarchies also makes combining with other ontologies harder as they will often use vessel vs vasculature interchangeably
We have two choices
- Retain current structure, but fully document, make DPs, and create procedures to avoid ragged hierarchies
- Collapse distinction, use vessel is-a hierarchy, add vasculature as synonyms, and if an application needs to refer to the merelogical sum of Xs and X-segments that are part of a P, then they do that using the base X concept and the complex axiomatization happens in that application
If we go with 1 then we need to be very clear about what X vasculature/musculature means. Is it all muscles part-of X? or part of and overlapping? or muscles and muscle parts that are in X? Is it the maximal mereological sum or any mereological sum?
This is actually a really hard thing to get right, and a harder thing to explain to people and to mentally reason over
For this reason, I am tending towards 2. However, this should not be done lightly. We need to look at implications for phenotype axiomatization some of which may depend on X vs Xature (specifically use of part-of vs is-a in uberon) to get desired inferences, cc @dosumis @matentzn
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.