objectionary / objectionary/lints

Unjustified xml-reason test packs require conversion or legitimate justification

Open
#1,475 0 comments 0 reactions 1 assignee View on GitHub

@volodya-lombrozo is already working on this.

Since Sep 16, 2026.

enhancement good-title
Dominant language
Java
Stars
14
Forks
39
Avg merge
22h 54m
Merged PRs (30d)
90

Description

#1463 added a check (LtByXslTest.checksDocumentUsageIsJustified) that fails when a pack uses document: (raw XMIR) without an xml-reason: key explaining why. To land that check without blocking on a full audit, I put a standard placeholder, xml-reason: "not yet converted to an EO input test", on the 156 packs I hadn't reviewed yet (only the 4 genuinely XML-only object-has-data packs got a real reason).

I need to go through those 156 packs one by one and, for each, either:

  • rewrite it using input: (EO source) when the pack doesn't rely on an invariant a valid EO parse can never produce, or
  • replace the placeholder with a real xml-reason: when raw XMIR is actually required.

The placeholder text is what makes the remaining work greppable: grep -rl 'not yet converted to an EO input test' src/test/resources/org/eolang/lints/packs.

Relevant classes to investigate: LtByXslTest, YamlPack.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.