objectionary / objectionary/lints

`unlint-non-existing-defect` benchmark lacks coverage for documents with `+unlint` metas, potentially missing regressions

Open
#1,284 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good-title
Dominant language
Java
Stars
14
Forks
39
Avg merge
22h 54m
Merged PRs (30d)
90

Description

I cannot tell whether objectionary/lints#1233 (or any future change to LtUnlintNonExistingDefect) is safe, because the only benchmark we have for that lint — the unlint-non-existing-defect entries in the README benchmark table — is driven by real-world bytecode-derived XMIR (com.sun.jna.*, org.apache.hadoop...FSNamesystem), none of which contain a single +unlint meta. That benchmark only measures the "no +unlint at all" fast path.

objectionary/lints#1233 changes the other path too: when +unlint metas are present, it now filters this.lints down to only the lints referenced by name before computing existingDefects(), instead of running the full list. We have no fixture with +unlint metas referencing defects that actually exist, so we have zero timing signal for that code path — no way to tell if it got faster, stayed the same, or regressed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the unlint-non-existing-defect entries in the README benchmark table and the LtUnlintNonExistingDefect implementation. Trace how +unlint metas select named lints and how existingDefects() is measured, then add a benchmark fixture containing +unlint metas that reference existing defects. Done means the README benchmark covers that path and provides timing for future regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
performance, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.