objectbox / objectbox/objectbox-dart
[BUG] `objectbox_flutter_libs@5.3.2` pub package files line endings was unconditionally changed
Nobody has claimed this yet.
- Dominant language
- Dart
- Stars
- 1.2k
- Forks
- 162
- Avg merge
- 15m
- Merged PRs (30d)
- 1
Description
Is there an existing issue?
- I have searched existing issues
Build info
- objectbox version: 5.3.2 (problematic), 5.3.1 (works)
- objectbox_flitter_libs version: 5.3.2 (problematic), 5.3.1 (works)
Context
I used the patch for objectbox_flutter_libs discribed in #808 in my tool I made for sandboxed offline flatpak builds of flutter apps.
I found the issue when I bumped from 5.3.1 to 5.3.2 the patch could not be applied with no changes cause somehow objectbox_flutter_libs@5.3.2 CMakeLists.txt got CLRF line endings. In 5.3.1 it has LF endings. Possibly somewho uses Windows to contribute.
So to apply same patch we should use something kinda that to avoid incompatibility
git diff --no-prefix --strip-trailing-cr > my_patch.patch
Expected behaviour
Better will be if you add .gitattributes file to your repo to avoid changing the line endings independend from which OS the files were edited
CMakeLists.txt text eol=lf
Additional data
You can find clarification about patch applying for objectbox_flutter_libs for versions: 5.3.1 and 5.3.2 in #808
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the objectbox_flutter_libs@5.3.1 and @5.3.2 package versions, focusing on the line endings in CMakeLists.txt and the requested .gitattributes behavior. Review the patch context in #808 and verify that the resulting package keeps the expected LF endings and remains usable with the documented patch process.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, dart, flutter
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 67/100