oasisprotocol / oasisprotocol/rofl-app
"Top up new machine based on last one" broken after an offer reduced resources
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 1
- Avg merge
- 46m
- Merged PRs (30d)
- 1
Description
"Top up new machine based on last one" uses the old offerId to try to get a machine that will work with old ORC.
But apparently offers can change how much disk space they offer while keeping the same id.
Not sure what happens with "Top up" to a machine that hasn't expired. Does it extend old resources but uses the new price?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of "Top up new machine based on last one" and trace how it uses offerId and handles machines that have not expired. Determine the expected behavior when an offer's resources change, then add or update coverage for the reduced-resource and unexpired-machine cases so the pricing and resource behavior are explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100