oasisprotocol / oasisprotocol/oasis-sdk
ts-web/core/signature:NaclSigner is evil and should be destroyed (or moved)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 90
- Forks
- 35
- Avg merge
- 5d 9h
- Merged PRs (30d)
- 5
Description
/**
* An in-memory signer based on tweetnacl. We've included this for development.
*/
The standard reservations about using Javascript/Typescript backed signing routines aside, this looks like something that exists for the purpose of examples, and not something that should be used seriously.
Instead of being part of the core SDK this should likely be moved to a test/examples extra package or something.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ts-web/core/signature and locate NaclSigner, then inspect how the core SDK currently exposes or uses it. Determine whether it belongs in a test/examples extra package as suggested; done means it is no longer part of the core SDK and the affected references remain usable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cryptography
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100