oasisprotocol / oasisprotocol/oasis-sdk

ts-web/core: remove unused, uncool dependencies

Open
#132 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

c:client-sdk/typescript c:testing enhancement
Dominant language
Rust
Stars
90
Forks
35
Avg merge
5d 9h
Merged PRs (30d)
5

Description

coming up in #119, we'll be adding standardized key derivation routines with some external libraries, including bip39 from npm. this one has some transitive dependencies that make the library harder to build for the web: https://github.com/oasisprotocol/oasis-sdk/pull/119#issuecomment-837465406. but it seems to go through stuff it won't need, e.g. some MD5 implementation.

  1. can we configure webpack not to worry about this part of the dependency tree and build our playground test without them?
  2. can we do something to make downstream devs not have to to worry about these either?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ts-web/core webpack configuration and the playground test setup, then inspect the bip39 dependency tree, including the referenced MD5 implementation. Done means the playground builds without unneeded transitive dependencies and downstream developers do not have to handle them.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, webpack
Domain
build-system, web-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.