oasisprotocol / oasisprotocol/oasis-sdk
storage: shorter key lifetime requirement
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 90
- Forks
- 35
- Avg merge
- 5d 9h
- Merged PRs (30d)
- 5
Description
pub fn tx_value<V>(&mut self, key: &str) -> &mut V
I think that the static requirement is a bit heavy, but w/e
Originally posted by @nhynes in https://github.com/oasisprotocol/oasis-sdk/pull/94#discussion_r612446418
for dispatch context and tx context value and tx_value (latter forthcoming) key parameter, currently requires &'static str
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating the dispatch-context and transaction-context value APIs, including the forthcoming tx_value, and inspect their key parameter lifetime bounds. Done means the APIs no longer require a static key lifetime while retaining the intended behavior and passing the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100