oasisprotocol / oasisprotocol/oasis-core
Streamline merges to master
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Infinitely rebasing ready-to-go PRs onto master is painful because
- rust tests take too long (leaving much time for other merges to cut in, which leads to a rebase, which requires more tests, which allows more merges, ...)
- GitHub review auto-dismissal is not smart enough to know that rebasing should not require more LGTMs
The rust tests will eventually be fixed (probably). The reasoning behind the auto-dismissal is valid, but the implementation leaves to be desired. How about we institute the practice of the person who created the PR should not be the one who merges it?
In a more perfect world, we have a buildbot which will re-request reviews based on our own heuristics.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points; start by reviewing the proposed merge practice, GitHub review auto-dismissal behavior, and the possible buildbot approach. Done would require an agreed maintainer workflow or a defined implementation plan for review re-request heuristics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, github, rust
- Domain
- ci-cd, developer-experience
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100