oasisprotocol / oasisprotocol/oasis-core
go/worker: Move storage initialization and registration to node initialization
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Client worker should not care about storage kind (see).
Instead storage should be initialized during node initialization, and passed to client and (storage) workers explicitly. (Or via runtime.Runtime.GetStorage).
Method runtime.Runtime.RegisterStorage should be removed which reduces complexity, worker coupling and is step towards testable workers.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading go/worker/client/worker.go around the storage handling and go/worker/storage/worker.go around storage registration. Trace node initialization and the runtime.Runtime RegisterStorage and GetStorage methods to understand the current flow. Done means storage is initialized at the node, passed explicitly to the client and storage workers or exposed through GetStorage, and RegisterStorage is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100