oasisprotocol / oasisprotocol/oasis-core
Unify OASIS_UNSAFE_SKIP_AVR_VERIFY semantics across Go and Rust attestation verification
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Harmless since debug flag for testing.
On the Rust side unsafe skip verify check is minimal:
https://github.com/oasisprotocol/oasis-core/blob/59b8f325ffd4d3ab4455b0495b78552a7b4d739e/runtime/src/common/sgx/pcs/quote.rs#L83-L88
On the go side, signature verification captures the quote verification against the policy that rust side may not ignore with unsafe skip verify set to true:
https://github.com/oasisprotocol/oasis-core/blob/59b8f325ffd4d3ab4455b0495b78552a7b4d739e/go/common/sgx/pcs/quote.go#L196-L200
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with go/common/sgx/pcs/quote.go and runtime/src/common/sgx/pcs/quote.rs at the linked verification logic. Compare how OASIS_UNSAFE_SKIP_AVR_VERIFY affects each path and trace the surrounding callers to determine the intended shared semantics. Done means Go and Rust handle the flag consistently; confirm the expected behavior and relevant tests before coding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, rust
- Domain
- cryptography, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100