oasisprotocol / oasisprotocol/oasis-core

go/runtime: Rename port configuration in per-component networking

Open
#6,264 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Description

SUMMARY

Simple per-component networking support was implemented in https://github.com/oasisprotocol/oasis-core/pull/6123. Unfortunately, the chosen naming of ports is confusing and I would strongly suggest to:

  • rename src_port to external_port (or host_port)
  • rename dst_port to internal_port (or component_port, instance_port or machine_port)
ISSUE TYPE
  • Feature Idea
COMPONENT NAME

go/runtime

ADDITIONAL INFORMATION

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the go/runtime per-component networking implementation introduced by PR 6123 and trace all uses of src_port and dst_port. Resolve the preferred replacement names from the issue discussion, update the related references, and verify that the networking behavior and existing tests still pass with the new terminology.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.