oasisprotocol / oasisprotocol/oasis-core
Fix the `keep_n` and `keep_last` naming
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
keep_n is for consensus, and keep_last is for runtimes.
Otherwise, they work exactly the same, just inconsistent naming.
However, we should fix the naming in the future to be consistent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names keep_n and keep_last but does not identify their files, definitions, or tests. Search the repository for both names, determine the intended consistent naming and all affected references, then verify that no old inconsistent usage remains.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100