oasisprotocol / oasisprotocol/oasis-core

protect mutex

Open
#5,243 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Description

go/common/grpc/grpc.go line 408
Code:
type Server struct {
sync.Mutex // <-- maybe not exposed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at go/common/grpc/grpc.go line 408 and inspect Server's synchronization and its callers. Confirm how the mutex is accessed and whether tests cover this behavior; done means the mutex is no longer exposed while server synchronization remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.