oasisprotocol / oasisprotocol/oasis-core
build/ci: ci-lint doesn't get skipped for dependabot PRs with fixups
Open
Nobody has claimed this yet.
c:bug
c:build
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
I shouldn't have to add a changelog fragment for dependabot PRs that require minor fixup commits. Neither an additional commit (ie: git commit --fixup HEAD) nor squashing the fixup onto the original dependabot commit skips ci-lint correctly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ci-lint logic that decides whether a Dependabot PR needs a changelog fragment, then compare its behavior with PR 4147. Reproduce both an additional fixup commit and a squashed fixup; done means neither case requires an unnecessary changelog fragment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100