oasisprotocol / oasisprotocol/oasis-core

mkvs: nested overlays

Open
#3,904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

c:runtime
Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Note that this way anything in the simulation context could still overwrite storage if it commits something. I think it is enough to mention this in the method documentation.

Originally posted by @kostko in https://github.com/oasisprotocol/oasis-sdk/pull/94#discussion_r622820346

over in SDK land we're doing "simulation," which would desire a nested overlay storage. what we have in OverlayTree wraps FallibleMKVS, and it panics on errors. maybe we could factor out the error-to-panic part so that in the SDK we could create an OverlayTree out of a &MKVS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the OverlayTree and FallibleMKVS implementations to understand how overlay storage and error handling currently interact. The work is done when nested overlays can support SDK simulation from an &MKVS, with the simulation-context storage caveat recorded in the method documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.