oasisprotocol / oasisprotocol/oasis-core
oasis-test-runner: Unify/cleanup repeated nodes configuration
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
Would be nice if we could unify/cleanup this as it is the same for every Node, but this is also true for the Node constructor above so probably best for a separate issue/PR.
Originally posted by @kostko in https://github.com/oasisprotocol/oasis-core/pull/3719#discussion_r586618958
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the oasis-test-runner code by locating the repeated configuration applied to each Node and compare it with the Node constructor mentioned in the issue. Confirm whether this issue should cover only the repeated node configuration, leaving constructor cleanup for a separate change; done means the in-scope configuration is unified without changing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100