oasisprotocol / oasisprotocol/oasis-core
go/common/crypto/signature/signers: Sort out the RPC situation
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
We now have 2 flavors of RPC backed signers:
signers/plugin- A simplifiednet/rpcinterface for use withgo-pluginsigners/remote- A more fully fleshed out gRPC interface for the remote-signer API.
We could consider unifying these as go-plugin supports plugins that use gRPC as the transport (though I do not know how nicely it plays with our custom codec situation).
The rationale for using net/rpc for the plugin signer was purely one of expediency, and I have no strong attachment to the interface, beyond "it works, so why mess with it". As the plugin package supports versioning I expect the transition to be fairly painless.
One side benefit of transitioning the plugin signer to gRPC would be the ability to write plugins in non-Go languages, but that also does not seem all that urgent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.