oasisprotocol / oasisprotocol/oasis-core
key manager: why do we sign in sign_public_key?
Open
Nobody has claimed this yet.
c:key management
s:need more info
- Dominant language
- Go
- Stars
- 369
- Forks
- 151
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 6
Description
why is it done in the method layer? should we worried, for example, that get_or_create_keys doesn't sign its output?
Details
encountered in keymanager-runtime/src/kdf.rs
from internal key manager audit
Acceptance Criteria
- none
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in keymanager-runtime/src/kdf.rs and compare sign_public_key with get_or_create_keys. Trace why signing occurs at the method layer and determine whether the unsigned output is intentional. The issue is done when the audit question has a documented decision and any required follow-up is identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cryptography, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100