key manager: generateStatus has some overlap with committee scheduler

Open
#2,190 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
go
Domain
blockchain

Research direction

Start in go/tendermint/apps/keymanager/keymanager.go and compare the generateStatus node-selection routine with the corresponding committee scheduler logic. Identify the shared runtime and capability checks, then consolidate them into one piece of code and verify that both callers retain their required behavior.

Written by the indexing model from the issue text.

Description

they both have a routine for finding registered nodes that support given runtime and with the right capabilities. might be able to consolidate some of that logic into a single piece of code

Details

encountered in go/tendermint/apps/keymanager/keymanager.go

from internal key manager audit

Acceptance Criteria

  • we consolidate that
Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oasisprotocol/oasis-core

All issues in oasisprotocol/oasis-core

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.