oasisprotocol / oasisprotocol/oasis-core

key manager: worker can die without crashing the node

Open
#2,187 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

c:key management
Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Description

early on in the worker goroutine, there's a place where it can die. it logs, but I think it doesn't crash the rest of the system, although I didn't test it

Details

encountered in go/keymanager/tendermint/tendermint.go

from internal key manager audit

Acceptance Criteria

  • that we don't blindly proceed with no worker. or we determine that it's best to proceed with no worker

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in go/keymanager/tendermint/tendermint.go and inspect the early worker-goroutine failure path that currently logs before the worker can die. Trace how the node responds when that path occurs, then establish whether the node must stop or can safely proceed without the worker. Done means the chosen behavior is enforced and verified for the worker-failure case.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.