oasisprotocol / oasisprotocol/oasis-core

[EXT-SEC-AUDIT] Excessive gRPC timeout

Open
#2,121 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

c:common c:security
Dominant language
Go
Stars
369
Forks
151
Avg merge
1d 3h
Merged PRs (30d)
6

Description

Issue transferred from an external security audit report.

Nodes are configured to use an excessively long timeout of 10 minutes when accepting
gRPC connections.

https://github.com/oasislabs/ekiden/blob/7a5ddc8fae312b6d8400fa9ba062604c1112c6a4/go/common/grpc/grpc.go#L71-L73

Short term, set MaxConnectionIdle to a lower value (e.g., 5 seconds).

Long term, make this value configurable to support applications that require a longer timeout. Ensure the default value is kept low, as recommended above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in go/common/grpc/grpc.go at the referenced MaxConnectionIdle configuration and inspect how gRPC connection options are constructed. Done means reducing the default timeout to a low value such as 5 seconds and making the value configurable for applications that need a longer timeout.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.